Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverting to asserts for non error checking assertions #3341

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Aug 13, 2024

Description

I went a bit too far with the changes in #3334.

It's inconvenient for developers to always use require. This updates the change so that they're only replced from assert when they evaluate errors.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated tests.

levkohimins
levkohimins previously approved these changes Aug 13, 2024
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

levkohimins
levkohimins previously approved these changes Aug 13, 2024
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhakbar
Copy link
Collaborator Author

yhakbar commented Aug 13, 2024

Have to fix some tests, so I moved the PR into WIP.

Copy link

sonarcloud bot commented Aug 13, 2024

@yhakbar yhakbar marked this pull request as ready for review August 13, 2024 20:59
@yhakbar yhakbar enabled auto-merge (squash) August 13, 2024 20:59
@levkohimins levkohimins self-requested a review August 13, 2024 21:24
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhakbar yhakbar merged commit dd602a3 into master Aug 13, 2024
4 checks passed
@yhakbar yhakbar deleted the fix/reverting-to-asserts branch August 13, 2024 21:24
akrantz01 pushed a commit to akrantz01/homelab that referenced this pull request Aug 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| patch | `v0.66.6` -> `v0.66.8` |
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| patch | `0.66.6` -> `0.66.8` |

---

### Release Notes

<details>
<summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary>

###
[`v0.66.8`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.8)

[Compare
Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.7...v0.66.8)

#### What's Changed

- chore: Bumping go version used during builds to `1.22` by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3346

**Full Changelog**:
gruntwork-io/terragrunt@v0.66.7...v0.66.8

###
[`v0.66.7`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.7)

[Compare
Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.6...v0.66.7)

#### What's Changed

- fix: Reverting to asserts for non error checking assertions by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3341
- fix: Updated documentation for --terragrunt-graph-root by
[@&#8203;denis256](https://github.com/denis256) in
[gruntwork-io/terragrunt#3344
- fix: Fixing remote state init skip by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3345
- chore: Adding `test` Lint Presets by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3340

**Full Changelog**:
gruntwork-io/terragrunt@v0.66.6...v0.66.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/akrantz01/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants