Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT_MERGE_YET] Add Lee's geometric controller #86

Draft
wants to merge 13 commits into
base: dev/ros-melodic
Choose a base branch
from

Conversation

gsilano
Copy link
Owner

@gsilano gsilano commented Nov 9, 2021

This pull request aims to integrate Lee's geometric controller implemented by Stefano Grossi into the CrazyS repository (i.e., Crazyflie 2.x simulator). It also tries to answer to the need for more control algorithms in the repo.

Linked issues: #43, #74, #75, #76, #77, #4, #71, #69, #68, #65, #50, #47, #45, #42, #36, #1, #15.

Stefano also made available a MATLAB script for running Lee's controller in MATLAB with Gazebo in the loop: https://github.com/gsilano/CrazyS/wiki/Interfacing-CrazyS-through-MATLAB

The code still needs some improvements to remove hard-coded parameters in the files.

Contributors: Stefano Grossi, Lorenzo Sabattini, Federico Pratissoli, and Beatrice Capelli. Giuseppe Silano helped with the integration in the CrazyS repository.

@gsilano gsilano self-assigned this Nov 9, 2021
@gsilano gsilano added the status: in progress This issue is being addressed already. To be applied to issues if they have a open PR label Nov 9, 2021
@gsilano
Copy link
Owner Author

gsilano commented Nov 14, 2021

Work has been done to remove hard-coded parameters in the controller. Also, Forster's parameters (see #56) are now an option for launch files. Although everything appears to be correct, the code still does not allow the drone to take off. This may require fine-tuning of the parameters (see crazyflie2_lee_controller_alpha.yaml file) or there may be typos in the code. Hope someone in the CrazyS community can help me with this.

@stale stale bot added the wontfix This will not be worked on label Apr 16, 2022
Repository owner deleted a comment from stale bot Apr 16, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2022
@gsilano gsilano mentioned this pull request Apr 16, 2022
@gsilano
Copy link
Owner Author

gsilano commented Apr 16, 2022

Add also a c++ script for publishing waypoints, as requested in #17.

@wawachen
Copy link

wawachen commented May 6, 2022

hi, when I run this node, it gives me the following error.
lee_position_controller_alpha_node: /usr/include/eigen3/Eigen/src/Core/DenseCoeffsBase.h:365: Eigen::DenseCoeffsBase<Derived, 1>::Scalar& Eigen::DenseCoeffsBase<Derived, 1>::operator()(Eigen::Index, Eigen::Index) [with Derived = Eigen::Matrix<double, 3, 3>; Eigen::DenseCoeffsBase<Derived, 1>::Scalar = double; Eigen::Index = long int]: Assertion `row >= 0 && row < rows() && col >= 0 && col < cols()' failed.

@gsilano
Copy link
Owner Author

gsilano commented May 6, 2022

Hi! As you can read from the title, the pull request is still in progress. As soon as the code integration is finished, I will join the master.

@pacificlion
Copy link

pacificlion commented Oct 19, 2022

Edit:
I was able to build the #86. I used ubuntu 18.04 with ros-melodic and followed steps of melodic and gazebo 9


Hi!
i wanted to contribute to this issue. I was able to execute examples using master branch. I am unable to successfully execute catkin build on #86. Can you please advise for same?

System

I am using ubuntu 20.04 with ros-noetic

Steps I followed

  1. I tried following README.md present in master branch as there was no README present in [NOT_MERGE_YET] Add Lee's geometric controller #86. I believe I may have to follow other instructions as they may not be valid for my configuration.

  2. I was able to follow till part 2 of installation steps. (except cloning [NOT_MERGE_YET] Add Lee's geometric controller #86 branch in catkin_ws)

  • in part 3, I faced issue while running:

rosdep install --from-paths src -i
image

  1. I am encountering issue while running catkin build . Initially, I got compilation issues related to opencv header files as mentioned below
    Screenshot from 2022-10-18 23-58-02
    which I resolved by following open-cv-git-issue and https://stackoverflow.com/a/72386873/.
    The changed files can be found at my fork for this PR: pull/lee_controller...pacificlion:CrazyS:pull/lee_controller

  2. After this, i was able to get pass compilation issues for rotors_gazebo_plugins:make, now getting issues for rotors_gazebo:make . Following is error screenshot
    Untitled

Stack Overflow
First the code:

#include <stdio.h>
#include <opencv2/opencv.hpp>
#include <opencv2/highgui/highgui.hpp>

using namespace cv;

int main( int argc, char** argv )
{
Mat image;

@gsilano
Copy link
Owner Author

gsilano commented Oct 23, 2022

Hi! Take a look at #40. This might solve your issue.

@gsilano gsilano marked this pull request as draft August 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress This issue is being addressed already. To be applied to issues if they have a open PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants