Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file path. #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

anthonyraf
Copy link

When pls config is called, it performs the same action as before but if -p or --path is added, it displays the file path instead of open the directory in explorer.

@anthonyraf
Copy link
Author

anthonyraf commented May 21, 2023

Sorry, I accidentally changed the CI file

@anthonyraf
Copy link
Author

@guedesfelipe Is the Windows CI failure related to the changes I've made ?

@guedesfelipe
Copy link
Owner

@guedesfelipe Is the Windows CI failure related to the changes I've made ?

Nops... I'll check that and fix the problem soon as possible.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.71%. Comparing base (7a81c0a) to head (c00845f).
Report is 23 commits behind head on main.

Files Patch % Lines
pls_cli/please.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   76.37%   75.71%   -0.67%     
==========================================
  Files           5        5              
  Lines         453      457       +4     
==========================================
  Hits          346      346              
- Misses        107      111       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"""Launch config directory :open_file_folder:"""
center_print(Rule('・Opening config directory・', style='#d77dd8'))
typer.launch(Settings().get_full_settings_path(), locate=True)
config_path = Settings().get_config_path()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command can stay within the scope where it is used.

Line 573

if not path:
center_print(
Rule(
f'・[white]Opening config directory ({config_path})[/]・',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove fixed styling in code?

[white][/]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants