Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning when compiling with Microsoft compiler #157

Closed
albert-github opened this issue Sep 12, 2022 · 1 comment
Closed

Warning when compiling with Microsoft compiler #157

albert-github opened this issue Sep 12, 2022 · 1 comment
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request Windows Windows platform is affected
Milestone
v1.5.14

Comments

@albert-github
Copy link
Contributor

With the Microsoft compiler (Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29914 for x64) we get the warning like:

warning C4191 'operator': unsafe conversion from 'type_of_expression' to 'type_required'

for:

filesystem/include/ghc/filesystem.hpp

Line 1959 in cd6805e

static CreateSymbolicLinkW_fp api_call = reinterpret_cast<CreateSymbolicLinkW_fp>(GetProcAddress(GetModuleHandleW(L"kernel32.dll"), "CreateSymbolicLinkW"));

and

filesystem/include/ghc/filesystem.hpp

Line 1983 in cd6805e

static CreateHardLinkW_fp api_call = reinterpret_cast<CreateHardLinkW_fp>(GetProcAddress(GetModuleHandleW(L"kernel32.dll"), "CreateHardLinkW"));

gulrak added a commit that referenced this issue Mar 4, 2023
@gulrak
refs #157, suppress unavoidable warning at cast for GetProcAddress on…
9df22d5 
… MSVC
@gulrak gulrak added enhancement New feature or request Windows Windows platform is affected labels Mar 4, 2023
@gulrak gulrak added this to the v1.5.14 milestone Mar 4, 2023
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Mar 4, 2023
@gulrak
Copy link
Owner

gulrak commented Mar 5, 2023

Released with v1.5.14.

@gulrak gulrak closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request Windows Windows platform is affected
Projects
None yet
Milestone
v1.5.14
Development

No branches or pull requests
2 participants
@gulrak @albert-github