Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build on Visual Studio 2019 #16

Closed
Mooseart opened this issue May 14, 2019 · 4 comments
Closed

Clean build on Visual Studio 2019 #16

Mooseart opened this issue May 14, 2019 · 4 comments
Assignees
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Milestone

Comments

@Mooseart
Copy link

I know your tests are currently not being run on 2019. I gave it a shot and tried to compile anyways. I got a bunch of warnings and an error in one of the examples. Error was easy enough to fix (missing include) but the warnings are mostly about template magic in some system header. I don't get it exactly but seems to be originating from the utf8 conversion somehow.
..so VS2019 build would be awesome to have. Thanks for sharing this great lib.

@gulrak
Copy link
Owner

gulrak commented May 15, 2019

Thank you for testing. Currently I don't have access to a system with an installed VC2019, so I couldn't check. I'll try to set up a VM with it, and look into it.

@gulrak gulrak self-assigned this May 15, 2019
@gulrak gulrak added the bug Something isn't working label May 15, 2019
@gulrak gulrak added this to the v1.1.6 milestone May 15, 2019
@gulrak gulrak added the question Further information is requested label May 15, 2019
@gulrak gulrak added available on master Fix is done on master branch, issue closed on next release and removed question Further information is requested labels May 15, 2019
@gulrak
Copy link
Owner

gulrak commented May 15, 2019

I revamped the char size dispatching, everything builds warning free and tests are running now on a VS2019 in my VM. Everything should be fine, but I will wait a few days before making a release, if something else comes up.

@Mooseart
Copy link
Author

Ah, nice! I've tested with your latest fix and it totally solves it on my side too. Thanks a lot for looking into it. I think you can close it then, unless you have any more work planned with respect to this.

@gulrak
Copy link
Owner

gulrak commented May 15, 2019

Thanks for rechecking!

@gulrak gulrak closed this as completed May 15, 2019
@gulrak gulrak modified the milestones: v1.1.6, v1.2.0 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants