Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing options parameter in copy #22

Closed
Jineapple opened this issue Aug 8, 2019 · 2 comments
Closed

Missing options parameter in copy #22

Jineapple opened this issue Aug 8, 2019 · 2 comments
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working high Severity: high
Milestone
v1.2.4

Comments

@Jineapple
Copy link

Jineapple commented Aug 8, 2019 •
edited
Loading

In line 3027 of filesystem.hpp, if the copy()-method resolves to a copy_file with two file paths given, the options parameter is not passed on.
copy_file(from, to, ec);
This causes issues e.g. if the target file already exists and overwrite_existing or update_existing was passed as an option.
@gulrak gulrak added bug Something isn't working high Severity: high labels Aug 8, 2019
@gulrak gulrak self-assigned this Aug 8, 2019
@gulrak gulrak added this to the v1.2.4 milestone Aug 8, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 8, 2019

Thanks for finding it! I will push a fix to master today, and scheduled a release for the weekend.

gulrak added a commit that referenced this issue Aug 9, 2019
@gulrak
refs #22, copy_options now forwarded to copy_file, added test.
8906e8c
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Aug 9, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 11, 2019

Fix released with v1.2.4

@gulrak gulrak closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working high Severity: high
Projects
None yet
Milestone
v1.2.4
Development

No branches or pull requests
2 participants
@gulrak @Jineapple