Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mingw missing preferred_separator #27

Closed
glebm opened this issue Aug 24, 2019 · 5 comments
Closed

mingw missing preferred_separator #27

glebm opened this issue Aug 24, 2019 · 5 comments
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Milestone
v1.2.6

Comments

@glebm
Copy link

glebm commented Aug 24, 2019 •
edited
Loading

Thank you for this library!

When using it with mingw, preferred_separator does not get defined:

undefined reference to `ghc::filesystem::path::preferred_separator'

https://ci.appveyor.com/project/sass/libsass/builds/26929504/job/jl88r6p7ci6bq9ad

This is with filesystem.hpp from master, mingw x86_64-4.9.2-release-win32-seh-rt_v4-rev3
@gulrak gulrak self-assigned this Aug 24, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 24, 2019

Yeah, sadly there was no test checking if the preferred_seperator works. I added one and compiling it fails with linker errors. I startet experimenting with a workaround. Still didn't check on mingw 4.9.2 but I also have some trouble with Visual Studio 2015 and the workaround.
GCC 4.9 also has some other issues concerning constexpr, so I might integrate a fall-back to const for pre 5.0 GCC. That needs to be checked.

@gulrak gulrak added the bug Something isn't working label Aug 27, 2019
@gulrak
Copy link
Owner

gulrak commented Aug 27, 2019

Just wanted to add, that I'm sorry, I need a few days for the fix, as I'm currently ill. Hopefully I'll get to it during the upcomming weekend. I started on it during last weekend on feature-27-mingw-preferred_separator, but as I said, MSVC 19.0 (Visual Studio 2015) has some problems left, and I didn't feel well enough to dig deeper.

@glebm
Copy link
Author

glebm commented Aug 27, 2019 •
edited
Loading

Get better soon!

Turns out I didn't even need preferred_separator, I just hadn't been aware that generic_u8string() exists.

@gulrak gulrak mentioned this issue Aug 27, 2019
Closed
@gulrak gulrak added this to the v1.2.6 milestone Aug 27, 2019
gulrak added a commit that referenced this issue Sep 21, 2019
@gulrak
refs #27, ghc::filesystem::path::preferred_seperator fix for VS2015
aabbf8f
gulrak added a commit that referenced this issue Sep 21, 2019
@gulrak
refs #27, Squashed commit of the following:
fbdee68 
commit aabbf8f
Author: Steffen Schümann <[email protected]>
Date:   Sat Sep 21 16:22:25 2019 +0200

    refs #27, ghc::filesystem::path::preferred_seperator fix for VS2015

commit 03b437c
Merge: cbe0c61 589219b
Author: Steffen Schümann <[email protected]>
Date:   Fri Sep 20 13:42:31 2019 +0200

    Merge branch 'master' into feature-27-mingw-preferred_separator

commit cbe0c61
Author: Steffen Schuemann <[email protected]>
Date:   Sat Aug 24 22:20:10 2019 +0200

    Test for workaround of static constexpr issue
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Sep 21, 2019
@gulrak
Copy link
Owner

gulrak commented Sep 21, 2019

Released with v1.2.6

@gulrak gulrak closed this as completed Sep 21, 2019
@glebm
Copy link
Author

glebm commented Sep 22, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Projects
None yet
Milestone
v1.2.6
Development

No branches or pull requests
2 participants
@glebm @gulrak