Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when building with Xcode 11.2 #36

Closed
arnaudbrejeon opened this issue Nov 6, 2019 · 2 comments
Closed

Warnings when building with Xcode 11.2 #36

arnaudbrejeon opened this issue Nov 6, 2019 · 2 comments
Assignees
Labels
available on master Fix is done on master branch, issue closed on next release
Milestone

Comments

@arnaudbrejeon
Copy link

Describe the bug
I get the following warning when building with Xcode 11.2:

Loop variable 's' has type 'const ghc::filesystem::path::string_type &' (aka 'const basic_string<char> &') but is initialized with type 'const ghc::filesystem::path' resulting in a copy

Inside path::parent_path implementation, this line:
for (const string_type& s : input_iterator_range<iterator>(begin(), --end())) {

Loop variable 's' has type 'const ghc::filesystem::path::string_type &' (aka 'const basic_string<char> &') but is initialized with type 'const ghc::filesystem::path' resulting in a copy

Inside path::lexically_normal implementation, this line:
for (const string_type& s : *this) {

Loop variable 'part' has type 'const path::string_type &' (aka 'const basic_string<char> &') but is initialized with type 'const ghc::filesystem::path' resulting in a copy
Inside create_directories implementation, this line:
for (const path::string_type& part : p) {

Would it be possible to remove them?

@gulrak gulrak self-assigned this Nov 6, 2019
@gulrak gulrak added this to the v1.2.8 milestone Nov 6, 2019
@gulrak
Copy link
Owner

gulrak commented Nov 6, 2019

Sure, I'll fix it.

@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Nov 7, 2019
@gulrak
Copy link
Owner

gulrak commented Nov 15, 2019

Released with v1.2.8

@gulrak gulrak closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master Fix is done on master branch, issue closed on next release
Projects
None yet
Development

No branches or pull requests

2 participants