Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexically_relative should ignore trailing slash on base #56

Closed
ligfx opened this issue Mar 22, 2020 · 0 comments · Fixed by #57
Closed

lexically_relative should ignore trailing slash on base #56

ligfx opened this issue Mar 22, 2020 · 0 comments · Fixed by #57
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Milestone
v1.3.2

Comments

@ligfx
Copy link
Contributor

ligfx commented Mar 22, 2020

Expected behavior

fs::path("a/b").lexically_relative("a") == "b";
fs::path("a/b").lexically_relative("a/") == "b";

Actual behavior

fs::path("a/b").lexically_relative("a/") == "b";
fs::path("a/b").lexically_relative("a/") == "../b";

(tested on AppleClang 11.0.0 on macOS 10.15.3)
@ligfx ligfx mentioned this issue Mar 22, 2020
Merged
gulrak added a commit that referenced this issue Mar 23, 2020
@gulrak
Merge pull request #57 from ligfx/fix_lexically_relative_to_path_with…
82d5d83 
…_trailing_slash

refs #56, lexically_relative: ignore trailing slash on base
@gulrak gulrak added available on master Fix is done on master branch, issue closed on next release bug Something isn't working labels Mar 23, 2020
@gulrak gulrak added this to the v1.3.1 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

lexically_relative: ignore trailing slash on base ligfx/filesystem
2 participants
@ligfx @gulrak