Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent handling of directory_options::skip_permission_denied #77

Closed
gulrak opened this issue Oct 24, 2020 · 1 comment
Closed

Inconsistent handling of directory_options::skip_permission_denied #77

gulrak opened this issue Oct 24, 2020 · 1 comment
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working macOS macOS platform is affected
Milestone
v1.3.8

Comments

@gulrak
Copy link
Owner

gulrak commented Oct 24, 2020

Describe the bug
While testing the POSIX implementation of the recursive_directory_iterator on macOS, I found the skip_permission_deniedoption to not work when iterating over my complete home directory hitting the ~/Library/Application Support/MobileSync folder. The increment still threw a filesystem_error. The reason is not wrong permissions, but "System Integrety Protection". The opendir results in an EPERM and not EACESS, and while EPERM was added to the increment handling of directory_iterator it is missing from the opendir error handling.

To Reproduce
Just try to iterate over a macOS SIP protected folder.

Expected behavior
The iterator should not enter the protected folder but continue to scan next to it.
@gulrak gulrak added bug Something isn't working macOS macOS platform is affected labels Oct 24, 2020
@gulrak gulrak self-assigned this Oct 24, 2020
@gulrak gulrak added this to the v1.3.8 milestone Oct 24, 2020
gulrak added a commit that referenced this issue Oct 24, 2020
@gulrak
refs #77, fix skip_permission_denied inconsistency
f824d0d
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Oct 24, 2020
@gulrak
Copy link
Owner Author

gulrak commented Nov 15, 2020

Released with v1.3.8

@gulrak gulrak closed this as completed Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working macOS macOS platform is affected
Projects
None yet
Milestone
v1.3.8
Development

No branches or pull requests
1 participant
@gulrak