Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for automatic selection of std/ghc filesystem on macOS in helper files and readme. #78

Closed
gulrak opened this issue Oct 24, 2020 · 1 comment
Closed

Better support for automatic selection of std/ghc filesystem on macOS in helper files and readme. #78

gulrak opened this issue Oct 24, 2020 · 1 comment
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request macOS macOS platform is affected
Milestone
v1.3.8

Comments

@gulrak
Copy link
Owner

gulrak commented Oct 24, 2020

Using __MAC_OS_X_VERSION_MIN_REQUIRED the header the decision to use std::filesystem or ghc::filesystem can correctly allow use of std::filesystem when deployment target is Catalina or newer, as the __cplusplus and header test are not enough to detect pre-Catalina conditions.
@gulrak gulrak added enhancement New feature or request macOS macOS platform is affected labels Oct 24, 2020
@gulrak gulrak added this to the v1.3.8 milestone Oct 24, 2020
@gulrak gulrak self-assigned this Oct 24, 2020
gulrak added a commit that referenced this issue Oct 25, 2020
@gulrak
refs #78, added test of __MAC_OS_X_VERSION_MIN_REQUIRED
416c60a
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Oct 27, 2020
@gulrak
Copy link
Owner Author

gulrak commented Nov 15, 2020

Released with v1.3.8

@gulrak gulrak closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request macOS macOS platform is affected
Projects
None yet
Milestone
v1.3.8
Development

No branches or pull requests
1 participant
@gulrak