Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid warning option on MSVC #95

Closed
phprus opened this issue Feb 9, 2021 · 2 comments
Closed

Invalid warning option on MSVC #95

phprus opened this issue Feb 9, 2021 · 2 comments
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release Windows Windows platform is affected
Milestone
v1.5.2

Comments

@phprus
Copy link
Contributor

phprus commented Feb 9, 2021

File: https://github.com/gulrak/filesystem/blob/master/cmake/GhcHelper.cmake#L53

Invalid option: /wd"4996" (error: cl : Command line error D8021 : invalid numeric argument '/wd"4996"')

Correct option: /wd4996 (MSDN: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-160)
gulrak added a commit that referenced this issue Feb 10, 2021
@gulrak
refs #95, fix MSVC warning syntax
2298e68
@gulrak gulrak self-assigned this Feb 10, 2021
@gulrak gulrak added the Windows Windows platform is affected label Feb 10, 2021
@gulrak
Copy link
Owner

gulrak commented Feb 10, 2021

Strangely I got no error with both syntaxes on my VS2019 installation or on AppVeyor with 2015/2017/2019 runs, but I changed it anyway. Thanks for reporting it.

@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Feb 10, 2021
@gulrak gulrak added this to the v1.5.2 milestone Feb 11, 2021
@gulrak
Copy link
Owner

gulrak commented Feb 27, 2021

This is now part of release v1.5.2

@gulrak gulrak closed this as completed Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release Windows Windows platform is affected
Projects
None yet
Milestone
v1.5.2
Development

No branches or pull requests
2 participants
@phprus @gulrak