Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define PATH_MAX if not defined by limits.h #138

Closed
wants to merge 1 commit into from
Closed

Define PATH_MAX if not defined by limits.h #138

wants to merge 1 commit into from

Conversation

Unit193
Copy link

@Unit193 Unit193 commented Dec 17, 2021

PATH_MAX is not portable, define it if it isn't defined in limits.h.

Not sure if this is where you'd prefer to define it though.

@gulrak gulrak added this to the 1.5.12 milestone Apr 2, 2022
@gulrak
Copy link
Owner

gulrak commented Apr 2, 2022

Sorry for the long delay, I implemented it almost as in your PR, but added a non-Windows dependency as PATH_MAX is not a thin on Windows and used by ghc::filesystem only for the POSIX backend.

gulrak added a commit that referenced this pull request Apr 2, 2022
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Apr 2, 2022
@gulrak gulrak self-assigned this Apr 2, 2022
@gulrak
Copy link
Owner

gulrak commented Apr 2, 2022

Manually adapted on master.

@gulrak gulrak closed this Apr 2, 2022
@Unit193
Copy link
Author

Unit193 commented Apr 2, 2022

Thanks! I'm not very picky, this looks great to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master Fix is done on master branch, issue closed on next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants