Allow wchar_t constructors of iostreams on Windows when using libc++ #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… __GNUC__ to __GLIBCXX__ as libc++ provides these on Windows as well
|
Thank you for the PR, that's a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to open files in eg. UTF-8 encoding the wchar_t functions must be used on Windows. Currently
__GNUC__is used as libstdc++ does not have a wchar_t constructor for it's ofstreams. Libc++ does on Windows however and matches Microsoft's behavior. This commit changes the check from__GNUC__, a macro that is also defined when using Clang with a*-*-windows-gnutriple, to instead check for libstdc++ through the__GLIBCXX__triple. This would even allow GCC to use these functions when using libc++.