Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support clang when we use autotools #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kjunichi
Copy link

Hello.

When I build http://www.geocities.jp/kosako3/oniguruma/archive/onig-5.9.5.tar.gz using qrintf clang as CC command, I notice that ./configure miss understood C89 option.

This patch solves it.

Sorry, I can't explain easyliy in English.

I worte blog article at http://kjunichi.cocolog-nifty.com/misc/2015/07/qrintfclangauto.html

thank you.

by the way, I heard rebuildfm 99 It was very interesting.

@kjunichi kjunichi mentioned this pull request Jul 14, 2015
@kazuho
Copy link
Member

kazuho commented Jul 14, 2015

Thank you for the PR. Will leave comments in-line.

@kazuho
Copy link
Member

kazuho commented Jul 14, 2015

Aside from the in-line comments, what is the expected behavior if more than one source files are specified together with -c option? (e.g. -c foo.c bar.c).

I would appreciate it if you could describe the expected behavior and confirm that the PR works correspondingly.

@kjunichi
Copy link
Author

Thank you for your comment.

The rewrite should not be limited to .c
Yes, you are right. I have no idea about that cases.

what is the expected behavior if more than one source files are specified together with -c option?
I expected foo.o,bar.o.

Now I think that It's better to change my logic.

Like this :
all processing is done,then add the following logic.
mv .o .o
and We don't need .i .
so rm .i

I think the filenames can be saved using hash table.

What do you think?

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants