Add more probes #299
Draft
Add more probes #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to consider is if we need frame-level ack probes. At the moment, we already have While it is helpful to have them when reading json directly, they might not be necessary when using a visualization tool that has the capability of deducing stream-level ACKs from stream-level send events and packet-level ACK events. Not having frame-level ACK probes would reduce the size of the eBPF program, which has to be kept below 4,096 instructions. @janaiyengar Do you have a preference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally speaking, we should have probe when any frame is sent, acked or received, regardless of the frame type. That would give us clear view of what is happening.
This PR is an attempt to do that.