-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create core/hab-bintray-publish
for Bintray publishing, right?
#709
Conversation
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
This change adds an additional piece of support software, under `support/bintray-publish`, which automates the delivery of `hab` CLI artifacts and Studio Docker images to Bintray for initial consumption. As all plans, this can be build with: hab pkg build ./support/bintray-publish Which produces a `core/hab-bintray-publish` package. There are 2 programs provided: * `publish-hab` - used to take a Habitat package of `hab` and publish it to Bintray * `publish-studio` - used to create and push a Docker image of a pre-created Studio instance Both of these programs require login credentials to do their work and these are consumed via environment variables. They will both fail if any of the required environment variables are not set, but for clarity, the following are used: * `BINTRAY_USER` - username * `BINTRAY_KEY` - an API key for the username * `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on the Bintray platform Signed-off-by: Fletcher Nichol <[email protected]>
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
ln -snf $certs /etc/ssl/certs/ca-certificates.crt | ||
fi | ||
export LD_LIBRARY_PATH="$LD_RUN_PATH" | ||
exec $(pkg_path_for glibc)/lib/ld-linux-x86-64.so.2 ${bin}.real \$@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man, really? we can't just patch the binary like normal humans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that the best? Turns out Go binaries are their own breed and patchelf has issues coping.
That function started off so wicked, until I needed SSL certs. From what I could tell Go doesn't honor any environment variables for these, but does absolute hard coded path lookups. The line 33-37 is evil, but the rest was almost a universal solution for cgo-compiled binary that we didn't build.
Also, I really wanted to see this frog fly, as is were. Whee!
This looks legit. Lets do it. |
📌 Commit 6f5d701 has been approved by |
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
This change adds an additional piece of support software, under `support/bintray-publish`, which automates the delivery of `hab` CLI artifacts and Studio Docker images to Bintray for initial consumption. As all plans, this can be build with: hab pkg build ./support/bintray-publish Which produces a `core/hab-bintray-publish` package. There are 2 programs provided: * `publish-hab` - used to take a Habitat package of `hab` and publish it to Bintray * `publish-studio` - used to create and push a Docker image of a pre-created Studio instance Both of these programs require login credentials to do their work and these are consumed via environment variables. They will both fail if any of the required environment variables are not set, but for clarity, the following are used: * `BINTRAY_USER` - username * `BINTRAY_KEY` - an API key for the username * `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on the Bintray platform Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
☀️ Test successful - travis |
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
This change adds an additional piece of support software, under `support/bintray-publish`, which automates the delivery of `hab` CLI artifacts and Studio Docker images to Bintray for initial consumption. As all plans, this can be build with: hab pkg build ./support/bintray-publish Which produces a `core/hab-bintray-publish` package. There are 2 programs provided: * `publish-hab` - used to take a Habitat package of `hab` and publish it to Bintray * `publish-studio` - used to create and push a Docker image of a pre-created Studio instance Both of these programs require login credentials to do their work and these are consumed via environment variables. They will both fail if any of the required environment variables are not set, but for clarity, the following are used: * `BINTRAY_USER` - username * `BINTRAY_KEY` - an API key for the username * `BINTRAY_PASSPHRASE` - the passphrase for the GPG-signing key on the Bintray platform Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #709 Approved by: adamhjk
This change adds an additional piece of support software, under
support/bintray-publish
, which automates the delivery ofhab
CLI artifacts and Studio Docker images to Bintray for initial consumption.As all plans, this can be build with:
Which produces a
core/hab-bintray-publish
package. There are 2 programs provided:publish-hab
- used to take a Habitat package ofhab
and publish it to Bintraypublish-studio
- used to create and push a Docker image of a pre-created Studio instanceBoth of these programs require login credentials to do their work and these are consumed via environment variables. They will both fail if any of the required environment variables are not set, but for clarity, the following are used:
BINTRAY_USER
- usernameBINTRAY_KEY
- an API key for the usernameBINTRAY_PASSPHRASE
- the passphrase for the GPG-signing key on the Bintray platform