Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytest-split in GHA test workflow #739

Merged
merged 6 commits into from
Apr 18, 2022
Merged

use pytest-split in GHA test workflow #739

merged 6 commits into from
Apr 18, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 25, 2022

Following the initially longer than expected runtime of pytest in #734, I looked around a bit for a pytest plugin that would automatically distribute the workload among multiple concurrent runners.

Luckily, exactly such a thing exists. Never used it before but looks great.

https://github.com/jerry-git/pytest-split

And they even have a GHA demo:

https://github.com/jerry-git/pytest-split-gh-actions-demo/tree/master/.github/workflows

Let's see if I set this up correctly. :)

@itsduowang
Copy link
Contributor

Hello @janosh! Sorry about the delay. I will merge this PR now and please let me know for any other problems or concerns.
Thank you for the contribution. Cheers! :)

@itsduowang itsduowang merged commit ee66a6e into hackingmaterials:main Apr 18, 2022
@janosh
Copy link
Member Author

janosh commented Apr 18, 2022

Tbh, I'm not sure the potential CI speed up from this change is worth the added complexity. I guess we can try it out on main and revert if it causes any issues.

@itsduowang
Copy link
Contributor

@janosh Sure thing!

@itsduowang
Copy link
Contributor

@janosh I think I need to revert this PR since several errors arose by the get_valid_path in drone.py from qchem package.

@janosh
Copy link
Member Author

janosh commented Apr 18, 2022

Feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants