Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BandCenter and IntersticeDistribution featurizers #897

Merged
merged 1 commit into from
May 26, 2023

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Mar 25, 2023

This PR simply initialises various data sources at the class or instance level, rather than in the featurizer loop, which was causing the data sources to be loaded from disk for every featurization leading to serious performance issues (as one might expect).

BandCenter, for example, is now 5 orders of magnitude faster on my machine.

I couldn't spot any other featurizers that have this issue though my search wasn't exhaustive.

@ml-evs
Copy link
Collaborator Author

ml-evs commented May 26, 2023

Only tests are failing as I don't have access to the MP API key from my fork, will merge this.

@ml-evs ml-evs merged commit f622439 into hackingmaterials:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant