Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for CI and tests #901

Merged
merged 8 commits into from
May 26, 2023
Merged

Fixes for CI and tests #901

merged 8 commits into from
May 26, 2023

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented May 20, 2023

Summary

  • The CI seems to have been broken for a while as mongo and mongosh disappeared? supercharge/mongodb-github-action#39 broke when GitHub actions updated the default runner to ubuntu-22.04. This PR replaces the use of this third-party action with a GH actions service container.

    Closes CI failing due to broken mongo service #900.

  • Also prevents hanging test for atomic packing by setting n_jobs to 1.

  • Also fixes MPRester regression for new system where MP API version is chosen dynamically and API key being set to None disables read of env var

  • Disables AFLOW tests in CI as they are failing for what seems like non-matminer-related reasons

  • Fixes test values for skewness and kurtosis tests, not sure what went wrong here but I don't see how these tests ever passed kurtosis of [1, 1, 1] is undefined, likewise skewness.

@ml-evs ml-evs changed the title Fix CI: Replace MongoDB marketplace action with service container Fixes for CI and tests May 21, 2023
@ml-evs ml-evs merged commit a3da199 into main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing due to broken mongo service
1 participant