Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the thermo tests rather than crash if MP API is missing #905

Merged
merged 1 commit into from
May 30, 2023

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented May 30, 2023

For the current released pymatgen version, creating an MPRester without an API key will raise a ValueError. This is fixed in the main pymatgen branch, but for now, this PR allows the tests to skip when no MP API key is present (as intended by the original code).

This should fix the test errors seen in #892 for @gbrunin.

@ml-evs ml-evs merged commit 29f13fd into main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant