Bug fixes in pseudo inverse computations #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were two small bugs in the pseudo inverse computations.
pymatgen.core.Element. Hydrogen's pseudo inverse was a third of what if should have been (sum of all isotope values). This affects the average slightly, so a few values in the tests had to be adapted.Additionally, I also had issues with pre-commit due to types-all, which has been deprecated, and I fixed it by listing all needed types.
Tests are passing in my branch with python 3.9 and 3.10, not with 3.11 but the tests that are failing are not related to these changes, so I don't know.