Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram is not shown for xcore files #112

Open
OepenerPlatt opened this issue Jun 18, 2020 · 11 comments
Open

Diagram is not shown for xcore files #112

OepenerPlatt opened this issue Jun 18, 2020 · 11 comments

Comments

@OepenerPlatt
Copy link

Hi,
the PlantUml view does not show the diagrams associated with xcore files.
It works correctly when a java file is opened in the editor.

I'm using the latest Eclipse 2020-06 and ran the updates. (Btw., it did not work in 2020-03 either).
Plantuml Ecore feature has version 1.1.24.

Any idea what am I doing wrong ?
Thanks.

@hallvard
Copy link
Owner

The xcore support hasn't been part of the update site for some time. I can add it to the next release, as a separately installable feature.

@hallvard hallvard added this to the 1.1.25 milestone Jun 19, 2020
@OepenerPlatt
Copy link
Author

Many many thanks !
I'm very interessted in that because I am currently working on an Xtext based DSL to modernize our IBMi (formerly AS/400) and CA2E (formerly Synon/2E) based development. I want to centralize the whole code base in the Eclipse ecosystem that we use since many years for the java client part (Eclipse E4 Rcp with xcore) and so called 'alienHelpers' that extend the traditional IBMi functionnality with the power of java.
PlantUml allows to give very good insights into the models at 'no cost'.

@hallvard hallvard removed this from the 1.1.25 milestone Apr 2, 2021
@itg-dave
Copy link

Any updates regarding the roadmap of this feature?

@yCactus
Copy link

yCactus commented Sep 29, 2023

@hallvard
Do you think it could be made available in a (not too far ...) future ? Would be greatly appreciated !

The xcore support hasn't been part of the update site for some time. I can add it to the next release, as a separately installable feature.

@OepenerPlatt
Copy link
Author

@hallvard
Any news about this feature ?
Could I possibly contribute/help in making it available again ?

@travkin79
Copy link
Collaborator

travkin79 commented Jan 2, 2024

Hi @OepenerPlatt,
It seems, @hallvard has no time for maintaining the PlantUML Eclipse plug-in. Maybe you could look at the latest source code, implement a fix in a pull request and I would try to merge it for the next release.

@OepenerPlatt
Copy link
Author

Hi @OepenerPlatt, It seems, @hallvard has no time for maintaining the PlantUML Eclipse plug-in. Maybe you could look at the latest source code, implement a fix in a pull request and I would try to merge it for the next release.

Hi @travkin79,
I would like to give it a try. Give me some time to find my way into the code.
Are there contribution guidelines to consider ?

@travkin79
Copy link
Collaborator

Hi @OepenerPlatt,
I'd say, create a fork / pull request, start your development in a new branch coming from the develop branch, use the issue number in the commits (#112), and check out the Readme.md files in the git repository. That's it 😄.

@OepenerPlatt
Copy link
Author

Hi @travkin79,
it took me some time, but I finally got the original functionality working in my fork.
Would you mind taking a look into my notes ? OepenerPlatt#11 (comment)
Maybe that we can discuss what (and how) I can contribute back to the original repo and what needs further investigation/discussion.

Many thanks.

@travkin79
Copy link
Collaborator

Hi @OepenerPlatt,
That are good news! Thank you very much. Unfortunately, I cannot look into the details before April. I'm currently not in office for some time. I'll take a look at your code when I'm back in office.
Best regards,
Dietrich

@OepenerPlatt
Copy link
Author

Dear @travkin79,
no problem.
There are still a couple of things I can fix or investigate in the meantime.

travkin79 added a commit that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants