Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when selecting (empty, non src) folder in Package Explorer #132

Closed
hallvard opened this issue Apr 26, 2021 · 3 comments
Closed

NPE when selecting (empty, non src) folder in Package Explorer #132

hallvard opened this issue Apr 26, 2021 · 3 comments
Assignees
Milestone

Comments

@hallvard
Copy link
Owner

I created a test folder named puml in a Java project and got an NPE when it was selected:

java.lang.NullPointerException: Cannot invoke "org.eclipse.core.runtime.IPath.toString()" because the return value of "net.sourceforge.plantuml.eclipse.utils.WorkbenchEditorPartDiagramIntentProviderContext.getPath()" is null
at net.sourceforge.plantuml.text.AbstractTextDiagramIntentProvider.getDiagramInfos(AbstractTextDiagramIntentProvider.java:53)
at net.sourceforge.plantuml.text.AbstractDiagramIntentProvider.getDiagramInfos(AbstractDiagramIntentProvider.java:119)
at net.sourceforge.plantuml.eclipse.views.AbstractDiagramSourceView.updateDiagramText(AbstractDiagramSourceView.java:517)

@hallvard hallvard self-assigned this Apr 26, 2021
@hallvard hallvard added this to the 1.1.26 milestone Apr 26, 2021
hallvard added a commit that referenced this issue Apr 28, 2021
@iloveeclipse
Copy link

Just saw this NPE in recent 1.1.25 version with following stack:

java.lang.NullPointerException
	at net.sourceforge.plantuml.text.AbstractTextDiagramIntentProvider.getDiagramInfos(AbstractTextDiagramIntentProvider.java:53)
	at net.sourceforge.plantuml.text.AbstractDiagramIntentProvider.getDiagramInfos(AbstractDiagramIntentProvider.java:119)
	at net.sourceforge.plantuml.eclipse.views.AbstractDiagramSourceView.updateDiagramText(AbstractDiagramSourceView.java:517)
	at net.sourceforge.plantuml.eclipse.views.AbstractDiagramSourceView.updateDiagramText(AbstractDiagramSourceView.java:442)
	at net.sourceforge.plantuml.eclipse.views.AbstractDiagramSourceView$DiagramTextChangedListener.diagramChanged(AbstractDiagramSourceView.java:349)
	at net.sourceforge.plantuml.eclipse.views.AbstractDiagramSourceView$DiagramTextChangedListener.selectionChanged(AbstractDiagramSourceView.java:344)
	at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyListeners(SelectionService.java:266)
	at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyListeners(SelectionService.java:180)
	at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partActivated(WorkbenchPage.java:220)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl$2.run(PartServiceImpl.java:249)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartActivated(PartServiceImpl.java:246)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:770)
	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:679)
	at org.eclipse.e4.ui.internal.workbench.swt.AbstractPartRenderer.activate(AbstractPartRenderer.java:97)

@hallvard : any ideas when the new 1.1.26 version will be released?

@hallvard
Copy link
Owner Author

hallvard commented Aug 23, 2021

1.1.26 is available on http://hallvard.github.io/plantuml/ now, could you please try it? If it works I will announce and release on GitHub.

@jfitzgeraldSF
Copy link

Thank you @hallvard! Just installed it. Working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants