Add precheck for empty data and value less than one tinybar (#346)

* Add precheck for empty data and value less than one tinybar Signed-off-by: nikolay <[email protected]> * Edit the error messsage Signed-off-by: nikolay <[email protected]> * Edit precheck Signed-off-by: nikolay <[email protected]> * Edit error message Signed-off-by: nikolay <[email protected]> * Edit error message Signed-off-by: nikolay <[email protected]>
hashgraph · Jul 19, 2022 · 30634b4 · 30634b4
1 parent acad2c7
commit 30634b4
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 0 deletions.
diff --git a/packages/relay/src/lib/errors.ts b/packages/relay/src/lib/errors.ts
@@ -101,4 +101,9 @@ export const predefined = {
     code: -32000,
     message: 'Insufficient funds for transfer'
   }),
+  'VALUE_TOO_LOW': new JsonRpcError({
+    name: 'Value too low',
+    code: -32602,
+    message: 'Value below 10_000_000_000 wei which is 1 tinybar'
+  }),
 };
diff --git a/packages/relay/src/lib/eth.ts b/packages/relay/src/lib/eth.ts
@@ -650,6 +650,7 @@ export class EthImpl implements Eth {
       await this.precheck.gasLimit(transaction);
       await this.precheck.nonce(transaction);
       this.precheck.chainId(transaction);
+      this.precheck.value(transaction);
     }
     catch(e: any) {
       return e;

diff --git a/packages/relay/src/lib/precheck.ts b/packages/relay/src/lib/precheck.ts
@@ -38,6 +38,13 @@ export class Precheck {
     this.logger = logger;
   }
 
+  value(transaction: string) {
+    const tx = ethers.utils.parseTransaction(transaction);
+    if (tx.data === EthImpl.emptyHex && tx.value.lt(constants.TINYBAR_TO_WEIBAR_COEF)) {
+      throw predefined.VALUE_TOO_LOW;
+    }
+  }
+
   /**
    * @param transaction
    */

diff --git a/packages/relay/tests/lib/precheck.spec.ts b/packages/relay/tests/lib/precheck.spec.ts
@@ -40,6 +40,9 @@ describe('Precheck', async function() {
 
     const txWithMatchingChainId = '0x02f87482012a0485a7a358200085a7a3582000832dc6c09400000000000000000000000000000000000003f78502540be40080c001a006f4cd8e6f84b76a05a5c1542a08682c928108ef7163d9c1bf1f3b636b1cd1fba032097cbf2dda17a2dcc40f62c97964d9d930cdce2e8a9df9a8ba023cda28e4ad';
     const txWithNonMatchingChainId = '0xf86a0385a7a3582000832dc6c09400000000000000000000000000000000000003f78502540be400801ca06750e92db52fa708e27f94f27e0cfb7f5800f9b657180bb2e94c1520cfb1fb6da01bec6045068b6db38b55017bb8b50166699384bc1791fd8331febab0cf629a2a';
+    const txWithValueMoreThanOneTinyBar = '0xf8628080809449858d4445908c12fcf70251d3f4682e8c9c381085174876e800801ba015ec73d3e329c7f5c0228be39bf30758f974d69468847dd507082c89ec453fe2a04124cc1dd6ac07417e7cdbe04cb99d698bddc6ce4d04054dd8978dec3493f3d2';
+    const txWithValueLessThanOneTinybar = '0xf8618080809449858d4445908c12fcf70251d3f4682e8c9c38108405f5e100801ba08249a7664c9290e6896711059d2ab75b10675b8b2ef7da41f4dd94c99f16f587a00110bc057ae0837da17a6f31f5123977f820921e333cb75fbe342583d278327d';
+    const txWithValueLessThanOneTinybarAndNotEmptyData = '0xf8638080809449858d4445908c12fcf70251d3f4682e8c9c3810830186a0831231231ba0d8d47f572b49be8da9866e1979ea8fb8060f885119aff9d457a77be088f03545a00c9c1266548930924f5f8c11854bcc369bda1449d203c86a15840759b61cdffe';
     const oneTinyBar = ethers.utils.parseUnits('1', 10);
     const defaultGasPrice = 720_000_000_000;
     const defaultChainId = Number('0x12a');
@@ -73,6 +76,38 @@ describe('Precheck', async function() {
         mock.reset();
     });
 
+    describe('value', async function() {
+        it('should throw an exception if value is less than 1 tinybar', async function() {
+            let hasError = false;
+            try {
+                precheck.value(txWithValueLessThanOneTinybar);
+            } catch (e) {
+                expect(e).to.exist;
+                expect(e.code).to.eq(-32602);
+                expect(e.message).to.eq('Value below 10_000_000_000 wei which is 1 tinybar');
+                hasError = true;
+            }
+
+            expect(hasError).to.be.true;
+        });
+
+        it('should pass if value is more than 1 tinybar', async function() {
+            try {
+                precheck.value(txWithValueMoreThanOneTinyBar);
+            } catch (e) {
+                expect(e).to.not.exist;
+            }
+        });
+
+        it('should pass if value is less than 1 tinybar and data is not empty', async function() {
+            try {
+                precheck.value(txWithValueLessThanOneTinybarAndNotEmptyData);
+            } catch (e) {
+                expect(e).to.not.exist;
+            }
+        });
+    });
+
     describe('chainId', async function() {
         it('should pass for matching chainId', async function() {
             try {