Ensure acceptance tests run on previewnet/testnet #351
Conversation
Signed-off-by: Ivo Yankov <[email protected]>
Ivo-Yankov
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 9 9
Lines 874 874
Branches 143 143
=======================================
Hits 545 545
Misses 291 291
Partials 38 38 Continue to review full report at Codecov.
|
| @@ -406,8 +407,10 @@ describe('RPC Server Acceptance Tests', function () { | |||
| const transaction = { | |||
| ...default155TransactionData, | |||
| to: mirrorContract.evm_address, | |||
| nonce: await relay.getAccountNonce(accounts[2].address) | |||
| nonce: await relay.getAccountNonce(accounts[2].address), | |||
There was a problem hiding this comment.
Why was lack of gasPrice working before.
Please add to comments section of PR something to highlight this issue and solution
|
|
||
| const transaction = { | ||
| ...defaultLondonTransactionData, | ||
| to: mirrorContract.evm_address, | ||
| nonce: await relay.getAccountNonce(accounts[2].address) | ||
| nonce: await relay.getAccountNonce(accounts[2].address), | ||
| maxPriorityFeePerGas: gasPrice, |
There was a problem hiding this comment.
Similar PR comments for this section as to why it works in local node but is an issue here
# Conflicts: # packages/server/tests/helpers/assertions.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Since the gas price is not static for the public networks some of the tests for |
Signed-off-by: Ivo Yankov [email protected]
Description:
Adjust the acceptance tests so that they run consistently against Testnet and Previewnet.
Some tests were failing with error
-32009: Gas price too lowdue to a higher gas price on the public networks than the default hardcoded one that is used when testing against the local node.When testing against Previewnet it turned out that the
chainIdvalue in the README was incorrect.Related issue(s):
Fixes #340
Notes for reviewer:
Checklist