Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release acceptance tests tag support #365

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 21, 2022

Description:
The acceptance tests suite is large.
In non-local envs this case result in expensive tests

  • Add a @release tag to core happy path tests
  • Add npm run command support to kick off filtered tests

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #365 (056edc0) into main (713567f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   62.35%   62.35%           
=======================================
  Files           9        9           
  Lines         866      866           
  Branches      142      142           
=======================================
  Hits          540      540           
  Misses        288      288           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713567f...056edc0. Read the comment docs.

@Nana-EC Nana-EC added this to In progress in Development via automation Jul 21, 2022
@Nana-EC Nana-EC added enhancement New feature or request process Build, test and deployment-process related tasks labels Jul 21, 2022
@Nana-EC Nana-EC self-assigned this Jul 21, 2022
@Nana-EC Nana-EC added the P2 label Jul 21, 2022
@Nana-EC Nana-EC marked this pull request as ready for review July 21, 2022 05:55
Signed-off-by: Nana-EC <[email protected]>
ar-conmit
ar-conmit previously approved these changes Jul 21, 2022
Copy link
Collaborator

@ar-conmit ar-conmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC requested a review from ar-conmit July 21, 2022 13:31
Copy link
Collaborator

@ar-conmit ar-conmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 21, 2022
@Nana-EC Nana-EC merged commit dad8a94 into main Jul 21, 2022
Development automation moved this from In progress to Done Jul 21, 2022
@Nana-EC Nana-EC deleted the release-acceptance-tests branch July 21, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants