Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truffle <> relay compatibility #379

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Truffle <> relay compatibility #379

merged 6 commits into from
Jul 26, 2022

Conversation

natanasow
Copy link
Collaborator

Signed-off-by: nikolay [email protected]

Description:

Related issue(s):

Fixes #312

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #379 (6f7a449) into main (5af00f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files           8        8           
  Lines         799      799           
  Branches      131      131           
=======================================
  Hits          586      586           
  Misses        171      171           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af00f9...6f7a449. Read the comment docs.

@natanasow
Edit package.json
39a0ece 
Signed-off-by: nikolay <[email protected]>
@Nana-EC Nana-EC added enhancement New feature or request limechain P2 dev tools Features enabling dev tool integration labels Jul 25, 2022
@Nana-EC Nana-EC added this to In progress in Development via automation Jul 25, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 25, 2022
Nana-EC
Nana-EC requested changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Some suggestions

tools/truffle-example/migrations/1_deploy_greeter.js Show resolved Hide resolved
tools/truffle-example/test/greeter.js Outdated Show resolved Hide resolved
tools/truffle-example/truffle-config.js Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kalina-Todorova Kalina-Todorova moved this from In progress to For Review in Development Jul 26, 2022
@natanasow natanasow requested a review from Nana-EC July 26, 2022 08:02
@natanasow natanasow merged commit acc4c9e into main Jul 26, 2022
Development automation moved this from For Review to Done Jul 26, 2022
@natanasow natanasow deleted the 312-truffle-relay-compatibility branch July 26, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@Daniel-K-Ivanov Daniel-K-Ivanov Awaiting requested review from Daniel-K-Ivanov

@ar-conmit ar-conmit Awaiting requested review from ar-conmit

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

Assignees

@natanasow natanasow

Labels
dev tools Features enabling dev tool integration enhancement New feature or request limechain P2
Projects
Development
Done
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Truffle <> relay compatibility
6 participants
@natanasow @codecov-commenter @Nana-EC @Ivo-Yankov @Daniel-K-Ivanov @ar-conmit