Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Services compilation check #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add Services compilation check #376

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f8fb5
Add Services compilation check
tinker-michaelj Jun 18, 2024
167a612
Use more flexible sed command
tinker-michaelj Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/validate-protobufs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Get PR branch name
id: pr_branch
run: echo "branch=${GITHUB_HEAD_REF}" >> $GITHUB_ENV

- name: Checkout hedera-services
uses: actions/checkout@v3
with:
Expand All @@ -22,7 +18,7 @@ jobs:

- name: Update hedera-services branch
run: |
sed -i 's/branch = "main"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts
sed -i.bak "s/branch = \".*\"/branch = \"${GITHUB_HEAD_REF}\"/" hedera-services/hapi/build.gradle.kts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something worth noting:
Sed is greedy by default, so this might match a lot more than we want, basically it will extend as far as it can without crossing to a new line. That shouldn't be an issue, unless someone puts a comment at end of line with a " in it, in which case this may break (that's why I restricted the match set in my suggestion).


- name: Run Gradle assemble
run: ./gradlew assemble
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be OK, but we might need to add the cgroup controls Nathan worked out for services to make sure the compile doesn't starve out the github agent on the runner.
Something to watch for.

Expand Down