Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

064 d freeze txn use instant #67

Merged
merged 4 commits into from
Aug 6, 2021
Merged

064 d freeze txn use instant #67

merged 4 commits into from
Aug 6, 2021

Conversation

ljianghedera
Copy link
Contributor

Description:
This PR added a new field Timestamp as freeze start time, meanwhile deprecated these 4 fields as freeze start time and duration:

  1. startHour
  2. startMin
  3. endHout
  4. endMin

Now once hedera services enter MAINTENANCE mode, it has to be manually taken down and up.

Related issue(s):

Fixes #64

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

ljianghedera and others added 3 commits July 29, 2021 15:22
@ljianghedera
Added start, end timestamp and deprecate start and end hours/mins
5fa43ae 
Signed-off-by: ljianghedera <[email protected]>
@ljianghedera
Add freeze start timestamp and deprecate start/end hour/min.
9d62a90 
Signed-off-by: ljianghedera <[email protected]>
Tweak comments and variable names for stylistic consistency (#66)
8c9b26b 
* Tweak comments and variable names for stylistic consistency

Signed-off-by: tinker-michaelj <[email protected]>

* Backwards compatibility

Signed-off-by: tinker-michaelj <[email protected]>
steven-sheehy
steven-sheehy approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Without an end time or a separate unfreeze transaction, how does the network get unfrozen?

@ljianghedera ljianghedera mentioned this pull request Aug 3, 2021
Closed
2 tasks
@anighanta
Copy link
Contributor

q: Without an end time or a separate unfreeze transaction, how does the network get unfrozen?

by restarting the Network afaik

tinker-michaelj
tinker-michaelj approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 384383f into develop Aug 6, 2021
@tinker-michaelj tinker-michaelj deleted the 064-D-freeze-txn-use-instant branch August 6, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@qnswirlds qnswirlds qnswirlds approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@anighanta anighanta anighanta approved these changes

@abhishek-hedera abhishek-hedera Awaiting requested review from abhishek-hedera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljianghedera @anighanta @steven-sheehy @qnswirlds @tinker-michaelj