-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comments to be consistent #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glanced through and it looked fine. Just clarifying if this change was done using an automated process? If so, that gives me high confidence that there wouldn't be any copy and mistake errors.
@steven-sheehy the process I used was to use VIM's built in comment formatter and macros. I would simply select the region to format and then hit a macro which would convert Big reason I had in my mind that this doesn't need to be completely automated is because this ideally shouldn't be an issue anymore. I'm hoping that if anyone reads the protobufs they'd be able to see the style guide for comments and follow it. I'm hoping that soon enough |
Seems like I got a bit of rebasing to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
Update comments to follow the same style; that style being Javadoc style:
Related issue(s):
Notes for reviewer:
Checklist