Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments to be consistent #73

Merged
merged 5 commits into from
Aug 26, 2021
Merged

Update comments to be consistent #73

merged 5 commits into from
Aug 26, 2021

Conversation

janaakhterov
Copy link
Contributor

Description:

Update comments to follow the same style; that style being Javadoc style:

/**
 * <comment>
 */

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@janaakhterov janaakhterov changed the title Fix/comments Update comments to be consistent Aug 14, 2021
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glanced through and it looked fine. Just clarifying if this change was done using an automated process? If so, that gives me high confidence that there wouldn't be any copy and mistake errors.

@janaakhterov
Copy link
Contributor Author

janaakhterov commented Aug 19, 2021

@steven-sheehy the process I used was to use VIM's built in comment formatter and macros. I would simply select the region to format and then hit a macro which would convert // into *, put /** before the selected region, and */ at the end of the selected region. Of course not all comments were formatted originally to start with // so I had to properly choose which macro to use. I've also use a little regex to format one line comments such as /* .* */. So this process wasn't completely automated, but it wasn't completely manual with copy and pasting either.

Big reason I had in my mind that this doesn't need to be completely automated is because this ideally shouldn't be an issue anymore. I'm hoping that if anyone reads the protobufs they'd be able to see the style guide for comments and follow it. I'm hoping that soon enough buf will have a built in formatter which we'd use instead of writing our own.

@janaakhterov
Copy link
Contributor Author

Seems like I got a bit of rebasing to do.

steven-sheehy
steven-sheehy previously approved these changes Aug 24, 2021
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 4b2a8bf into hashgraph:develop Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants