Max automatic token associations #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge in TransactionRecord Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
…count can be involved in Signed-off-by: anighanta <[email protected]>
anighanta
requested review from
tinker-michaelj and
steven-sheehy
and removed request for
tinker-michaelj
anighanta
requested review from
tinker-michaelj,
rbair23,
abhishek-hedera and
qnswirlds
qnswirlds
previously approved these changes
Aug 17, 2021
steven-sheehy
previously approved these changes
Aug 17, 2021
ijungmann
reviewed
Aug 17, 2021
services/CryptoUpdate.proto
Outdated
| @@ -53,4 +53,5 @@ message CryptoUpdateTransactionBody { | |||
| google.protobuf.BoolValue receiverSigRequiredWrapper = 13; // If true, this account's key must sign any transaction depositing into this account (in addition to all withdrawals) | |||
| } | |||
| google.protobuf.StringValue memo = 14; // If set, the new memo to be associated with the account (UTF-8 encoding max 100 bytes) | |||
| google.protobuf.UInt32Value max_automatic_token_associations = 15; // The maximum number of tokens that an Account can be implicitly associated with. Up to a 1000 including implicit and explicit associations. | |||
There was a problem hiding this comment.
I'm confused by the second part of this comment. Is this saying the total max associations is 1000? I would just have it similar to how it is in CryptoCreate
ijungmann
previously approved these changes
Aug 17, 2021
Nana-EC
previously approved these changes
Aug 17, 2021
|
Need to signoff your commits to pass DCO |
xin-hedera
reviewed
Aug 18, 2021
services/BasicTypes.proto
Outdated
| @@ -465,6 +465,7 @@ message TokenRelationship { | |||
| TokenKycStatus kycStatus = 4; // The KYC status of the account (KycNotApplicable, Granted or Revoked). If the token does not have KYC key, KycNotApplicable is returned | |||
| TokenFreezeStatus freezeStatus = 5; // The Freeze status of the account (FreezeNotApplicable, Frozen or Unfrozen). If the token does not have Freeze key, FreezeNotApplicable is returned | |||
| uint32 decimals = 6; // Tokens divide into <tt>10<sup>decimals</sup></tt> pieces | |||
| bool automatic_association = 7; // Specifies if the relationship is created implicitly. False : explicitly associated, True : implicitly associated. | |||
There was a problem hiding this comment.
does the current state hold the explicit / implicit info, just not exposed?
xin-hedera
previously approved these changes
Aug 18, 2021
abhishek-hedera
previously approved these changes
Aug 18, 2021
added 2 commits
August 19, 2021 16:35
Signed-off-by: tinker-michaelj <[email protected]>
tinker-michaelj
dismissed stale reviews from abhishek-hedera, xin-hedera, Nana-EC, ijungmann, and steven-sheehy
via
95890ad
tinker-michaelj
dismissed stale reviews from qnswirlds and themself
via
95890ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #80
Notes for reviewer:
Added a new field to specify the max automaic associations that an Account can be involved in
Checklist