Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response code for Auto Association limit reached #83

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

anighanta
Copy link
Contributor

Description:

Related issue(s):
Added a new response code EXISTING_AUTOMATIC_ASSOCIATIONS_EXCEED_GIVEN_LIMIT for Auto Association limit reached

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj tinker-michaelj merged commit 03115a3 into develop Aug 23, 2021
@tinker-michaelj tinker-michaelj deleted the add-ResponseCode-AutoAssiciation branch August 23, 2021 22:15
Comment on lines +274 to +275
NO_REMAINING_AUTO_ASSOCIATIONS = 262; // The account has reached the limit on the automatic associations count.
EXISTING_AUTOMATIC_ASSOCIATIONS_EXCEED_GIVEN_LIMIT = 263; // Already existing automatic associations are more than the new maximum automatic associations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pick both AUTO or AUTOMATIC for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants