Change max_automatic_token_associations to int32 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
xin-hedera
requested review from
steven-sheehy,
qnswirlds,
tinker-michaelj,
anighanta,
ljianghedera and
abhishek-hedera
steven-sheehy
approved these changes
Sep 2, 2021
qnswirlds
approved these changes
Sep 2, 2021
abhishek-hedera
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the type of
max_automatic_token_associationstoint32/Int32Value.Related issue(s):
Fixes #
Notes for reviewer:
The corresponding type of protobuf
uint32in Java isint. Since the allowed value will never be more than int32 max, we should change it toint32to avoid unnecessary unsigned conversion in Java code.Checklist