Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable create2 server tests #97

Closed
acuarica opened this issue Dec 11, 2023 · 3 comments · Fixed by #164
Closed

Enable create2 server tests #97

acuarica opened this issue Dec 11, 2023 · 3 comments · Fixed by #164
Assignees

Comments

@acuarica
Copy link
Contributor

The endpoints missing are

  • /session/verify/create2
  • /session/verify/create2/compile
  • /verify/create2
@Nana-EC
Copy link
Collaborator

Nana-EC commented Dec 13, 2023

@acuarica do we recall why these endpoints don't work. I believe it had to do with the session key not being used in our case.

@acuarica
Copy link
Contributor Author

It is because a config flag, create2, needs to be set to make them available.

@svienot
Copy link
Contributor

svienot commented Dec 14, 2023

So this is a configurability we have added. We decided to (at least initially) hide the Create2 verification because it was not clear how useful it was in our context... So the feature is currently not enabled in the UI, and the corresponding end-points are also not exposed.
When we forked, the Create2 verification was supposed to imply that the client provide a TOKEN, in order to avoid spamming. The server was configured for all supported tokens via the .env file.
I saw recently that in today's sourcify.dev the functionality has evolved such that this TOKEN business is gone and the user seems to have to login to be able to use this feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants