Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use upstream Sourcify images #164

Merged
merged 72 commits into from
May 28, 2024

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Apr 23, 2024

Description:

This PR updates the configuration to consume upstream Sourcify images server and repository directly. We keep the ui image in this repo as it needs specific Hedera customizations. See #147 for more details.

The unused packages and src folders will be removed in PR #170 to ease the review of this one.

Related issue(s):

Fixes #147.
Fixes #141.
Fixes #145.
Fixes #101.
Fixes #98.
Fixes #97.
Fixes #89.

Notes for reviewer:

  • The compose.yaml provides a blueprint on how to build and run the images. Also it can be useful for development purposes.
  • The data folder is just a placeholder to mount repository contracts.
  • Most of the deleted files from the test folder were unused before this PR. These were removed here to avoid any future tech debt.
  • The tests that are left provide a last validation of Sourcify server.
  • There are now 2 patches, one for server and one for repository. This can be triggered from package.json.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica linked an issue Apr 23, 2024 that may be closed by this pull request
13 tasks
@acuarica acuarica force-pushed the 147-use-upstream-sourcify-images-as-a-dependency branch from e8c90a7 to 0d9b6de Compare April 24, 2024 16:21
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Moreover, it includes docs for the `SERVER_URL` env var

Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
This reverts commit 441d632.

Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica marked this pull request as ready for review May 21, 2024 22:44
@acuarica acuarica requested review from a team as code owners May 21, 2024 22:44
@acuarica acuarica requested review from quiet-node, Sheng-Long, svienot and ericleponner and removed request for a team May 21, 2024 22:44
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Just some validating questions

.github/workflows/release-integration.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ui/public/config.json Show resolved Hide resolved
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Nana-EC
Nana-EC previously approved these changes May 28, 2024
Signed-off-by: Luis Mastrangelo <[email protected]>
Copy link
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

server.patch Show resolved Hide resolved
servers.yaml Show resolved Hide resolved
@Nana-EC Nana-EC merged commit e313ed0 into main May 28, 2024
7 checks passed
@Nana-EC Nana-EC deleted the 147-use-upstream-sourcify-images-as-a-dependency branch May 28, 2024 16:42
@acuarica acuarica added the enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label May 30, 2024
beeradb pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
3 participants