fix: remove session endpoints and fix server drop-down #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Mastrangelo <[email protected]>
2 tasks
acuarica
changed the title
Signed-off-by: Luis Mastrangelo <[email protected]>
acuarica
requested review from
quiet-node,
Sheng-Long and
Reccetech
and removed request for
a team
Nana-EC
approved these changes
Jan 11, 2024
|
If we do not remove the Session API endpoints from the spec, we might want to give a stronger warning than “not supported”. In fact no client code running in a browser is ever going to be able to call these endpoints (unless the corresponding domain is configured as an Other than that, looks good to me. |
Signed-off-by: Luis Mastrangelo <[email protected]>
svienot
approved these changes
Jan 16, 2024
Nana-EC
reviewed
Jan 17, 2024
Co-authored-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Luis Mastrangelo <[email protected]>
13 tasks
acuarica
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove session endpoints so that we can share the api-docs. Also fix the server drop-down which was showing always the local dev server.
I have included both prod and local server in the drop-down, but maybe the Current REST API server suffices.
Default server value
When the user opens the servers drop-down
Session endpoints label
Related issue(s):
Fixes #
Notes for reviewer:
Checklist