chore: remove unused config files #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
|
@svienot @rustyShacklefurd I would like your input here, is there something else we should remove? |
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
These configs have been superseded by `docker-compose-hedera.yaml`. Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
This looks good.
|
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
acuarica
requested review from
quiet-node,
Sheng-Long,
svienot,
rustyShacklefurd and
ericleponner
and removed request for
a team
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
|
@svienot @rustyShacklefurd when you have a bit of time, please take a look at this PR, thanks. |
svienot
approved these changes
Apr 24, 2024
acuarica
deleted the
142-clean-up-unused-files-and-services-from-the-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR cleans up the repo by removing unused files coming from Sourcify.
.circlecithis is used by upstream Sourcify, not us.vscodeandui/.vscodeunused launch configurationstslint.jsonold lint settings, superseded by.eslintrc.jsf855a1cservices/ipfsunused image, see https://docs.sourcify.dev/docs/repository/#ipfsservices/s3syncunused image, see https://docs.sourcify.dev/docs/repository/#s3-bucketsome files from
scripts/that might be used by upstream Sourcify 78c4de9, 93b5dde and ca75ec2.github/PULL_REQUEST_TEMPLATE/release.mdunused PR template ad266cdscripts/hedera-reset-(previewnet|testnet).shinvokehedera-reset.shdirectly frompackage.json'sscriptsto avoid indirection andscriptsfolder pollution 9de95ddenvironments/(build-)?(ipfs|monitor|s3).yamldocker related configs for unused services a61b2ebmonitorservice related files c04daf2environments/(grafana|loki-config|promtail-config).yamlsatellite service configs 0740bc2environments/(repository|server|ui).yamlHederacomposeconfigs superseded bydocker-compose-hedera.yamlb8068f7environments/.env.(dev|latest|stable)upstream Sourcify.envconfig files not used by Hedera 51eed0eenvironments/.env.secrets.gpgunused secrets b3fe100 and related config files 8fa438dui/.env.(development|production)old env var templates and updateui/.gitignoreaccordingly 99a009aThis PR is a pre-step towards issue #147, where upstream Sourcify images will be consumed directly (except
ui).The
ui's landing page is also unused and needs to be removed. However, because removing a page would also require updating theui/package.json's dependencies, its removal is implemented as part of #160.Related issue(s):
Fixes #142.
Notes for reviewer:
The amount of files removed in this PR got larger then I expected. As a recommendation, it might be easier for reviewers to look at each commit individually. Moreover, next to each item is the commit that delete it.