Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add unified workflow to publish both prod and integration images #178

Merged
merged 3 commits into from
May 29, 2024

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented May 28, 2024

Description:

This PR merges both production and integration release image workflows into one.

Related issue(s):

Fixes #177.

Notes for reviewer:

To test this workflow you can use act https://nektosact.com/ to run actions locally.

Important

Please note that while it is expected the act command itself fails due to Main Login to GitHub Container Registry, it is important you see in the output the expected line.

Tip

You may want to append --container-architecture linux/amd64 to each of these commands if you're using an Apple M-series chip.

push to main.

act push --workflows .github/workflows/push-images.yaml

The following line should appear in the console output

[Publish Images to GitHub Registry/docker-image-publish]   ⚙  ::set-env:: TAG=main

push vX.Y.Z tag

Create a file event.json

{
  "ref": "refs/tags/vX.Y.Z"
}
act push --workflows .github/workflows/push-images.yaml --eventpath event.json 

The following line should appear in the console output

[Publish Images to GitHub Registry/docker-image-publish]   ⚙  ::set-env:: TAG=X.Y.Z

workflow_dispatch.

act workflow_dispatch --workflows .github/workflows/push-images.yaml --input version=test

The following line should appear in the console output

[Publish Images to GitHub Registry/docker-image-publish]   ⚙  ::set-env:: TAG=test

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica changed the title Add unified workflow to publish both prod and integration images build: add unified workflow to publish both prod and integration images May 29, 2024
@acuarica acuarica marked this pull request as ready for review May 29, 2024 12:57
@acuarica acuarica requested review from a team as code owners May 29, 2024 12:57
@acuarica acuarica requested review from david-bakin-sl, Sheng-Long, svienot and beeradb and removed request for a team May 29, 2024 12:57
@acuarica acuarica merged commit 5445414 into main May 29, 2024
9 of 11 checks passed
@acuarica acuarica deleted the 177-update-release-production-workflow branch May 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release production environment workflow to use new image name scheme
2 participants