Skip to content

Commit

Permalink
provider/azure: update vmss doc only supporting unique deployment mode
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonodonnell committed Jul 19, 2024
1 parent 38e67cb commit 7e417b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions provider/azure/azure_discover.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ func (p *Provider) Help() string {
When using tags the only permission needed is Microsoft.Network/networkInterfaces/*
When using Virtual Machine Scale Sets the only role action needed is Microsoft.Compute/virtualMachineScaleSets/*/read.
The Azure provider only supports Virtual Machine Scale Sets deployed in [Uniform mode](https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-orchestration-modes#scale-sets-with-uniform-orchestration).
As of 2023 VMSS deploys using Flexible mode by default.
It is recommended you make a dedicated key used only for auto-joining.
`
Expand Down Expand Up @@ -130,7 +132,6 @@ func (p *Provider) Addrs(args map[string]string, l *log.Logger) ([]string, error
l.Printf("[ERROR] discover-azure: resource_group %s, vm_scale_set %s", resourceGroup, vmScaleSet)
return nil, fmt.Errorf("discover-azure: unclear configuration. use (tag name and value) or (resouce_group and vm_scale_set)")
}

}

func fetchAddrsWithTags(tagName string, tagValue string, vmnet network.InterfacesClient, l *log.Logger) ([]string, error) {
Expand All @@ -139,7 +140,6 @@ func fetchAddrsWithTags(tagName string, tagValue string, vmnet network.Interface

ctx := context.Background()
netres, err := vmnet.ListAll(ctx)

if err != nil {
return nil, fmt.Errorf("discover-azure: %s", err)
}
Expand Down

0 comments on commit 7e417b1

Please sign in to comment.