Skip to content

Commit

Permalink
Merge pull request #34443 from hashicorp/td-chimesdkvoice_sdkv2
Browse files Browse the repository at this point in the history
td/chime service -> sdkv2
  • Loading branch information
johnsonaj committed Nov 16, 2023
2 parents 6f7ff93 + 14110e1 commit 4b389cd
Show file tree
Hide file tree
Showing 32 changed files with 460 additions and 428 deletions.
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/athena v1.34.1
github.com/aws/aws-sdk-go-v2/service/auditmanager v1.29.1
github.com/aws/aws-sdk-go-v2/service/bedrock v1.3.1
github.com/aws/aws-sdk-go-v2/service/chimesdkvoice v1.11.2
github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.7.0
github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.14.2
github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.27.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ github.com/aws/aws-sdk-go-v2/service/auditmanager v1.29.1 h1:qeUpRNt719FxxOv0OIb
github.com/aws/aws-sdk-go-v2/service/auditmanager v1.29.1/go.mod h1:Ta+K43GimomnNMOSgZBHDy6itNw8zfhcJoSVkLWCPiE=
github.com/aws/aws-sdk-go-v2/service/bedrock v1.3.1 h1:lAbJ/wQ96QZPbgMGkwy4MkwYBE0fSkHrsCqpdzKB8FA=
github.com/aws/aws-sdk-go-v2/service/bedrock v1.3.1/go.mod h1:T6sGivDDiUgXY/R3+S9t5oRR0XJiUeKAXyyw3LRdTK4=
github.com/aws/aws-sdk-go-v2/service/chimesdkvoice v1.11.2 h1:BOhDhkslpSqyye38XkGuYRtKc2K+LUARi40+nLfFZns=
github.com/aws/aws-sdk-go-v2/service/chimesdkvoice v1.11.2/go.mod h1:ugdoQ39F3IjYNFnWgPqruX04VpJLYlvZ/Ncv/UOT2lM=
github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.7.0 h1:Tzr0M3HxHIjFtxxPzsKE9xeLOrWCfJXl5HDCgkmiylE=
github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.7.0/go.mod h1:1uZJJhBfD+zak0t687UE2IQ8t8hugY6bpM67IpLcYK8=
github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.14.2 h1:wm8zm7z6Gl+5O4K5DbZAm1Q37W2SGX4OrP9VOVPuHvc=
Expand Down
6 changes: 3 additions & 3 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/service/chime/generate.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

//go:generate go run ../../generate/tags/main.go -ListTags -ListTagsInIDElem=ResourceARN -ServiceTagsSlice -TagInIDElem=ResourceARN -UpdateTags -AWSSDKServicePackage=chimesdkvoice
//go:generate go run ../../generate/tags/main.go -AWSSDKVersion=2 -ListTags -ListTagsInIDElem=ResourceARN -ServiceTagsSlice -TagInIDElem=ResourceARN -UpdateTags -AWSSDKServicePackage=chimesdkvoice
//go:generate go run ../../generate/servicepackage/main.go
// ONLY generate directives and package declaration! Do not add anything else to this file.

Expand Down
36 changes: 18 additions & 18 deletions internal/service/chime/tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 24 additions & 22 deletions internal/service/chime/voice_connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,17 @@ import (
"context"
"log"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/chimesdkvoice"
"github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/chimesdkvoice"
awstypes "github.com/aws/aws-sdk-go-v2/service/chimesdkvoice/types"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
"github.com/hashicorp/terraform-provider-aws/internal/conns"
"github.com/hashicorp/terraform-provider-aws/internal/enum"
"github.com/hashicorp/terraform-provider-aws/internal/errs"
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
tftags "github.com/hashicorp/terraform-provider-aws/internal/tags"
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
Expand All @@ -42,11 +44,11 @@ func ResourceVoiceConnector() *schema.Resource {
Computed: true,
},
"aws_region": {
Type: schema.TypeString,
ForceNew: true,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice(chimesdkvoice.VoiceConnectorAwsRegion_Values(), false),
Type: schema.TypeString,
ForceNew: true,
Optional: true,
Computed: true,
ValidateDiagFunc: enum.Validate[awstypes.VoiceConnectorAwsRegion](),
},
"name": {
Type: schema.TypeString,
Expand Down Expand Up @@ -84,7 +86,7 @@ func resourceVoiceConnectorDefaultRegion(ctx context.Context, diff *schema.Resou

func resourceVoiceConnectorCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).ChimeSDKVoiceConn(ctx)
conn := meta.(*conns.AWSClient).ChimeSDKVoiceClient(ctx)

createInput := &chimesdkvoice.CreateVoiceConnectorInput{
Name: aws.String(d.Get("name").(string)),
Expand All @@ -93,24 +95,24 @@ func resourceVoiceConnectorCreate(ctx context.Context, d *schema.ResourceData, m
}

if v, ok := d.GetOk("aws_region"); ok {
createInput.AwsRegion = aws.String(v.(string))
createInput.AwsRegion = awstypes.VoiceConnectorAwsRegion(v.(string))
}

resp, err := conn.CreateVoiceConnectorWithContext(ctx, createInput)
resp, err := conn.CreateVoiceConnector(ctx, createInput)
if err != nil || resp.VoiceConnector == nil {
return sdkdiag.AppendErrorf(diags, "creating Chime Voice connector: %s", err)
}

d.SetId(aws.StringValue(resp.VoiceConnector.VoiceConnectorId))
d.SetId(aws.ToString(resp.VoiceConnector.VoiceConnectorId))

return append(diags, resourceVoiceConnectorRead(ctx, d, meta)...)
}

func resourceVoiceConnectorRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).ChimeSDKVoiceConn(ctx)
conn := meta.(*conns.AWSClient).ChimeSDKVoiceClient(ctx)

resp, err := FindVoiceConnectorResourceWithRetry(ctx, d.IsNewResource(), func() (*chimesdkvoice.VoiceConnector, error) {
resp, err := FindVoiceConnectorResourceWithRetry(ctx, d.IsNewResource(), func() (*awstypes.VoiceConnector, error) {
return findVoiceConnectorByID(ctx, conn, d.Id())
})

Expand Down Expand Up @@ -139,7 +141,7 @@ func resourceVoiceConnectorRead(ctx context.Context, d *schema.ResourceData, met

func resourceVoiceConnectorUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).ChimeSDKVoiceConn(ctx)
conn := meta.(*conns.AWSClient).ChimeSDKVoiceClient(ctx)

if d.HasChanges("name", "require_encryption") {
updateInput := &chimesdkvoice.UpdateVoiceConnectorInput{
Expand All @@ -148,7 +150,7 @@ func resourceVoiceConnectorUpdate(ctx context.Context, d *schema.ResourceData, m
RequireEncryption: aws.Bool(d.Get("require_encryption").(bool)),
}

if _, err := conn.UpdateVoiceConnectorWithContext(ctx, updateInput); err != nil {
if _, err := conn.UpdateVoiceConnector(ctx, updateInput); err != nil {
return sdkdiag.AppendErrorf(diags, "updating Voice connector (%s): %s", d.Id(), err)
}
}
Expand All @@ -158,14 +160,14 @@ func resourceVoiceConnectorUpdate(ctx context.Context, d *schema.ResourceData, m

func resourceVoiceConnectorDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).ChimeSDKVoiceConn(ctx)
conn := meta.(*conns.AWSClient).ChimeSDKVoiceClient(ctx)

input := &chimesdkvoice.DeleteVoiceConnectorInput{
VoiceConnectorId: aws.String(d.Id()),
}

if _, err := conn.DeleteVoiceConnectorWithContext(ctx, input); err != nil {
if tfawserr.ErrCodeEquals(err, chimesdkvoice.ErrCodeNotFoundException) {
if _, err := conn.DeleteVoiceConnector(ctx, input); err != nil {
if errs.IsA[*awstypes.NotFoundException](err) {
log.Printf("[WARN] Chime Voice connector %s not found", d.Id())
return diags
}
Expand All @@ -175,14 +177,14 @@ func resourceVoiceConnectorDelete(ctx context.Context, d *schema.ResourceData, m
return diags
}

func findVoiceConnectorByID(ctx context.Context, conn *chimesdkvoice.ChimeSDKVoice, id string) (*chimesdkvoice.VoiceConnector, error) {
func findVoiceConnectorByID(ctx context.Context, conn *chimesdkvoice.Client, id string) (*awstypes.VoiceConnector, error) {
in := &chimesdkvoice.GetVoiceConnectorInput{
VoiceConnectorId: aws.String(id),
}

resp, err := conn.GetVoiceConnectorWithContext(ctx, in)
resp, err := conn.GetVoiceConnector(ctx, in)

if tfawserr.ErrCodeEquals(err, chimesdkvoice.ErrCodeNotFoundException) {
if errs.IsA[*awstypes.NotFoundException](err) {
return nil, &retry.NotFoundError{
LastError: err,
LastRequest: in,
Expand Down
Loading

0 comments on commit 4b389cd

Please sign in to comment.