Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: SageMaker Studio now supports custom images for Code Editor Applications #37153

Closed
michaelneely opened this issue Apr 29, 2024 · 6 comments · Fixed by #37155
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@michaelneely
Copy link

Description

Similarly to JupyterLab and Kernel Gateway apps, AWS Sagemaker now supports using custom images for Code Editor applications, see the docs here.

This would be a relatively quick addition to add in the aws_sagemaker_domain resource.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_domain" "code_editor_domain" {

  default_user_settings {

    code_editor_app_settings {
      custom_image = [
        app_image_config_name = aws_sagemaker_app_image_config.example.app_image_config_name
        image_name            = aws_sagemaker_image_version.example.image_name
        image_version         = 1
      ]
    }
  }
}

References

  1. https://docs.aws.amazon.com/sagemaker/latest/dg/code-editor-custom-images-provide-access.html
  2. https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-sagemaker-studio-code-editor-custom-images/

Would you like to implement a fix?

Yes

@michaelneely michaelneely added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 29, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Apr 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2024
@tkimble-cafeyn
Copy link

Would be cool to add a code_repository block as well. Something like this:

code_repository {
  repository_url = "repo_url.git"
}

@damianslee
Copy link

any update sagemaker domain to support codeeditor custom images

app image config already supports codeeditor custom images, but can not use it cause its missing from sagemaker domains
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sagemaker_app_image_config

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.56.0 milestone Jun 21, 2024
Copy link

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
4 participants