-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/37153: Add custom_image to code_editor_app_settings in Sagemaker user profile and domain #37155
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @michaeljneely 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DrFaust92 - may I request a re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMaker_serial/Domain/codeEditorAppSettings\|TestAccSageMaker_serial/UserProfile/codeEditorAppSettings' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run=TestAccSageMaker_serial/Domain/codeEditorAppSettings\|TestAccSageMaker_serial/UserProfile/codeEditorAppSettings -timeout 360m
=== RUN TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT TestAccSageMaker_serial
=== RUN TestAccSageMaker_serial/UserProfile
=== RUN TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage
user_profile_test.go:283: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN TestAccSageMaker_serial/Domain
=== RUN TestAccSageMaker_serial/Domain/codeEditorAppSettings_customImage
domain_test.go:660: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN TestAccSageMaker_serial/Domain/codeEditorAppSettings
--- PASS: TestAccSageMaker_serial (250.85s)
--- PASS: TestAccSageMaker_serial/UserProfile (0.00s)
--- SKIP: TestAccSageMaker_serial/UserProfile/codeEditorAppSettings_customImage (0.00s)
--- PASS: TestAccSageMaker_serial/Domain (250.84s)
--- SKIP: TestAccSageMaker_serial/Domain/codeEditorAppSettings_customImage (0.00s)
--- PASS: TestAccSageMaker_serial/Domain/codeEditorAppSettings (250.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 255.470s
@michaeljneely Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS Sagemaker supports custom images for CodeEditor applications.
Custom images can be added via
aws_sagemaker_user_profile.user_settings.code_editor_app_settings
oraws_sagemaker_domain.default_user_settings.code_editor_app_settings
Relations
Closes #37153
References
Output from Acceptance Testing
I've added tests but can't run them myself. I would be grateful if someone could confirm these tests pass successfully.