Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_ec2_transit_gateway_peering_attachments #37016

Conversation

gramsa49
Copy link
Contributor

@gramsa49 gramsa49 commented Apr 20, 2024

Description

New Data Source: aws_ec2_transit_gateway_peering_attachments

Relations

Closes #25743

Output from Acceptance Testing

% make testacc TESTS=TestAccTransitGatewayPeeringAttachmentsDataSource PKG=ec2
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGatewayPeeringAttachmentsDataSource'  -timeout 360m
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        0.205s [no tests to run]

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/L Managed by automation to categorize the size of a PR. labels Apr 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 20, 2024
@gramsa49 gramsa49 changed the title New Data Source: transitgateway_peering_attachments New Data Source: aws_ec2_transit_gateway_peering_attachments Apr 20, 2024
@gramsa49
Copy link
Contributor Author

Is there anything that can be done to get this PR reviewed (prioritization)?

I read through the prioritization guide, but I don't see any avenues that can assist.
This introduces a new data source that makes it possible to do things that are not otherwise possible (multiple TGWs in the same account with a set of peering agreements).

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@ewbankkit ewbankkit self-assigned this Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 28, 2024
# Conflicts:
#	internal/service/ec2/service_package_gen.go
@ewbankkit ewbankkit requested a review from a team as a code owner June 28, 2024 19:58
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/PeeringAttachments' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/PeeringAttachments -timeout 360m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
--- PASS: TestAccTransitGatewayDataSource_serial (0.00s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter (271.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	275.818s

@ewbankkit
Copy link
Contributor

@gramsa49 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f5803ec into hashicorp:main Jun 28, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.57.0 milestone Jun 28, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New datasource: aws_ec2_transit_gateway_peering_attachments (plural)
3 participants