-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f-aws_paymentcryptography_key_alias #37021
f-aws_paymentcryptography_key_alias #37021
Conversation
Community NoteVoting for Prioritization
For Submitters
|
1e130cf
to
371e263
Compare
@meetreks I'm getting a false negative using |
We have been asking for a resolution for this....looks like its no longer required to check the endpoints..Kit is aware... |
We use the check because it's fast and easy and was 80-90% accurate. It's especially helpful with things like GovCloud where everything is different. As a team we haven't decided to stop using it but where it's not working, obviously, we can avoid it. It does create work later though when we're going through GovCloud test results and need to find another way of skipping tests rather than failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
% make t T=TestAccPaymentCryptographyKeyAlias_ K=paymentcryptography
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/paymentcryptography/... -v -count 1 -parallel 20 -run='TestAccPaymentCryptographyKeyAlias_' -timeout 360m
=== RUN TestAccPaymentCryptographyKeyAlias_basic
=== PAUSE TestAccPaymentCryptographyKeyAlias_basic
=== RUN TestAccPaymentCryptographyKeyAlias_disappears
=== PAUSE TestAccPaymentCryptographyKeyAlias_disappears
=== RUN TestAccPaymentCryptographyKeyAlias_update
=== PAUSE TestAccPaymentCryptographyKeyAlias_update
=== RUN TestAccPaymentCryptographyKeyAlias_updateName
=== PAUSE TestAccPaymentCryptographyKeyAlias_updateName
=== CONT TestAccPaymentCryptographyKeyAlias_basic
=== CONT TestAccPaymentCryptographyKeyAlias_update
=== CONT TestAccPaymentCryptographyKeyAlias_disappears
=== CONT TestAccPaymentCryptographyKeyAlias_updateName
--- PASS: TestAccPaymentCryptographyKeyAlias_disappears (18.93s)
--- PASS: TestAccPaymentCryptographyKeyAlias_basic (21.52s)
--- PASS: TestAccPaymentCryptographyKeyAlias_update (30.29s)
--- PASS: TestAccPaymentCryptographyKeyAlias_updateName (32.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/paymentcryptography 34.811s
This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
New resource for managing AWS Payment Cryptography keys alias
Relations
Closes #37020
References
https://docs.aws.amazon.com/payment-cryptography/latest/APIReference/API_CreateAlias.html
Output from Acceptance Testing