Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_paymentcryptography_key_alias #37021

Merged

Conversation

meetreks
Copy link
Contributor

Description

New resource for managing AWS Payment Cryptography keys alias

Relations

Closes #37020

References

https://docs.aws.amazon.com/payment-cryptography/latest/APIReference/API_CreateAlias.html

Output from Acceptance Testing

make testacc TESTS=TestAccCheckKeyAlias_ PKG=paymentcryptography

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. labels Apr 21, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Apr 21, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@YakDriver YakDriver self-assigned this Jun 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 4, 2024
@YakDriver YakDriver force-pushed the f_aws_paymentcryptography_create_alias branch from 1e130cf to 371e263 Compare June 4, 2024 13:22
@YakDriver
Copy link
Member

@meetreks I'm getting a false negative using acctest.PreCheckPartitionHasService(t, names.PaymentCryptographyEndpointID). Something somewhere is not updated. Not sure whether on our side or the AWS side. For now, I'm just commenting out and we can revisit.

@meetreks
Copy link
Contributor Author

meetreks commented Jun 4, 2024

@meetreks I'm getting a false negative using acctest.PreCheckPartitionHasService(t, names.PaymentCryptographyEndpointID). Something somewhere is not updated. Not sure whether on our side or the AWS side. For now, I'm just commenting out and we can revisit.

We have been asking for a resolution for this....looks like its no longer required to check the endpoints..Kit is aware...

@YakDriver
Copy link
Member

YakDriver commented Jun 4, 2024

We use the check because it's fast and easy and was 80-90% accurate. It's especially helpful with things like GovCloud where everything is different. As a team we haven't decided to stop using it but where it's not working, obviously, we can avoid it. It does create work later though when we're going through GovCloud test results and need to find another way of skipping tests rather than failing.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

% make t T=TestAccPaymentCryptographyKeyAlias_ K=paymentcryptography
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/paymentcryptography/... -v -count 1 -parallel 20 -run='TestAccPaymentCryptographyKeyAlias_'  -timeout 360m
=== RUN   TestAccPaymentCryptographyKeyAlias_basic
=== PAUSE TestAccPaymentCryptographyKeyAlias_basic
=== RUN   TestAccPaymentCryptographyKeyAlias_disappears
=== PAUSE TestAccPaymentCryptographyKeyAlias_disappears
=== RUN   TestAccPaymentCryptographyKeyAlias_update
=== PAUSE TestAccPaymentCryptographyKeyAlias_update
=== RUN   TestAccPaymentCryptographyKeyAlias_updateName
=== PAUSE TestAccPaymentCryptographyKeyAlias_updateName
=== CONT  TestAccPaymentCryptographyKeyAlias_basic
=== CONT  TestAccPaymentCryptographyKeyAlias_update
=== CONT  TestAccPaymentCryptographyKeyAlias_disappears
=== CONT  TestAccPaymentCryptographyKeyAlias_updateName
--- PASS: TestAccPaymentCryptographyKeyAlias_disappears (18.93s)
--- PASS: TestAccPaymentCryptographyKeyAlias_basic (21.52s)
--- PASS: TestAccPaymentCryptographyKeyAlias_update (30.29s)
--- PASS: TestAccPaymentCryptographyKeyAlias_updateName (32.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/paymentcryptography	34.811s

@YakDriver YakDriver merged commit 117471b into hashicorp:main Jun 4, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 4, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: aws_paymentcryptography_key_alias
3 participants