Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes tags in data sources #37966

Merged
merged 27 commits into from
Jun 14, 2024
Merged

Fixes tags in data sources #37966

merged 27 commits into from
Jun 14, 2024

Conversation

gdavison
Copy link
Contributor

Description

A number of data sources were not correctly returning tag values.

Relations

Closes #37916
Closes #37886

@gdavison gdavison requested a review from a team as a code owner June 13, 2024 21:21
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. service/s3 Issues and PRs that pertain to the s3 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/rds Issues and PRs that pertain to the rds service. service/sqs Issues and PRs that pertain to the sqs service. service/acm Issues and PRs that pertain to the acm service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/batch Issues and PRs that pertain to the batch service. labels Jun 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 13, 2024
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/acmpca Issues and PRs that pertain to the acmpca service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. tags Pertains to resource tagging. generators Relates to code generators. service/amp Issues and PRs that pertain to the amp service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/ipam Issues and PRs that pertain to the ipam service. service/logs Issues and PRs that pertain to the logs service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/transitgateway Issues and PRs that pertain to the transitgateway service. labels Jun 13, 2024
@gdavison gdavison force-pushed the b-data-cloudwatch-log-group branch from be47d55 to 92b3a20 Compare June 14, 2024 02:10
@gdavison gdavison merged commit 2577bda into main Jun 14, 2024
38 checks passed
@gdavison gdavison deleted the b-data-cloudwatch-log-group branch June 14, 2024 06:33
@github-actions github-actions bot added this to the v5.54.0 milestone Jun 14, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jun 14, 2024
Update CHANGELOG.md for #37966
a728346
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
@justinretzolk justinretzolk mentioned this pull request Jul 9, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/appmesh Issues and PRs that pertain to the appmesh service. service/batch Issues and PRs that pertain to the batch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/iam Issues and PRs that pertain to the iam service. service/ipam Issues and PRs that pertain to the ipam service. service/lambda Issues and PRs that pertain to the lambda service. service/logs Issues and PRs that pertain to the logs service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sqs Issues and PRs that pertain to the sqs service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.54.0
2 participants
@gdavison @ewbankkit