-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback when AWS SDK returns invalid FIPS endpoint when global UseFIPSEndpoint
is set
#38057
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
7ee3087
to
3a6b098
Compare
This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When the global setting
UseFIPSEndpoint
is set, the AWS SDK returns an API endpoint matching a specific pattern that indicates a FIPS endpoint, even if the region does not have a FIPS endpoint implemented. This has been causing a number of Terraform failures.Endpoint resolution now verifies that the returned endpoint can be resolved using DNS. If not, it falls back to the non-FIPS endpoint.
Relations
Closes #23619
Closes #34171
Closes #25732
Closes #22573
Closes #19346