-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reload service registration configuration on SIGHUP #17598
reload service registration configuration on SIGHUP #17598
Conversation
4858d8f
to
bf741bf
Compare
can we get some traction on this? Vault should have the ability to reload |
37fb07d
to
0b566c1
Compare
@VioletHynes - was hoping to take advantage of your offer while the iron is hot. Not sure if this applied to only the consul-template repo. |
Applies here too! I'll try and get some eyes on it, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm just looking into a panic that was thrown from one of the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that I didn't pick this up before, but one of the tests showed that ServiceRegistration can be nil, which leads to a panic.
beed434
to
33fbc46
Compare
Thanks for your submission @kevinschoonover! ❤️ |
If the consul token is ever rotated in a service configuration on disk, vault will never pick up the changes and will be unable to perform future service registrations.
This change reloads the configuration for service registrations whenever vault receives SIGHUP for consul by recreating the consul client since consul doesn't have a clear API for editting an agent's ACL token.
You can test these changes locally by:
kill -HUP $(pidof vault)