Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove leading slash from kv version 2 secret path #25874

Merged

Conversation

hellobontempo
Copy link
Contributor

Typically we avoid sanitizing in the UI to minimize data manipulation, however we decided to strip secret paths of the leading slash to copy CLI functionality.

 vault kv put -mount=kv /my-secret foo=my-long-passcode
== Secret Path ==
kv/data/my-secret

======= Metadata =======
Key                Value
---                -----
created_time       2024-03-11T16:59:42.502882Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            1
⇒ vault kv put -mount=kv //my-secret foo=my-long-passcode
== Secret Path ==
kv/data/my-secret

======= Metadata =======
Key                Value
---                -----
created_time       2024-03-11T17:00:01.047652Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            2

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Mar 11, 2024

Build Results:
All builds succeeded! ✅

Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefs-kiss:

@hellobontempo hellobontempo added this to the 1.15.7 milestone Mar 12, 2024
@hellobontempo hellobontempo merged commit 0d71b2a into main Mar 12, 2024
33 of 35 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-24467/remove-leading-slash-kv-secret-path branch March 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants