Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new "Invalid Token" Error Message #25953

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Mar 14, 2024

Adds the "Invalid Token" error message to the error response whenever (1) the token is revoked (2) the token does not exist, (3) the token lease is expired, (4) the token is some hocus value.

We've decided to add this value to the error message instead of replace it essentially allows all other subsystems to work as it was working previously, but adds an extra layer of information for Agent and Proxy to use when identifying when to retrigger auto auth.

Link to ENT Pr: https://github.com/hashicorp/vault-enterprise/pull/5588
closes https://github.com/hashicorp/vault-enterprise/pull/5588

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 14, 2024
@divyaac divyaac added this to the 1.17.0-rc milestone Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Mar 14, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we should change improvement to change in the release note, but otherwise LGTM :D

changelog/25953.txt Outdated Show resolved Hide resolved
Edited changelog

Added dummy policy to CE file to make tests pass

Added changelog
@divyaac divyaac force-pushed the VAULT_23740_Invalid_Token_Description_Change branch from 474a309 to 0e19c15 Compare March 14, 2024 17:55
@divyaac divyaac merged commit 74abae6 into main Mar 14, 2024
78 checks passed
@divyaac divyaac deleted the VAULT_23740_Invalid_Token_Description_Change branch March 14, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants